haskell
package page adjustments
summary
Some cosmetic improvements
Feel free to accept only a subset of the commits, they're very much all proposals.
Sadly I cannot upload some of the pictures of the changes since github doesn't feel like it today
remove unnecessary visual noise:
- remove the side bar
- remove padding and margin on the left and right sides
previously
now
build in a tiny bit of semantic html
- made the main part of the side somewhat navigatable
move maintainer's corner to the sidebar and hide it by default
- it's the maintainer's corner it shouldn't steal the average visitor large parts of their field of view
make clear what Package Description refers to
- there's an explainer already so no harm done in telling that this refers to the cabal file (I had to look this up myself :P)
Yes, please!
In the "previously" you have screenshots for both desktop and mobile but for "now" it's only mobile. Is it possible to get desktop too?
Is it possible to get desktop too?
Yesterday GitHub didn’t wanna :P
I can try again today
@MangoIV do you think you have addressed all @gbaz's comments? If yes, please, request another review from them.
@ulysses4ever whats your opinion on hiding maintainers corner by default? If there are no other opinions I’ll switch back to not hiding by default like @gbaz requested…
I often seek the list of maintainers as defined by Hackage, not the cabal file, so I'd definitely not want to be "hidden" by default. Sidebar is a good place, I think.
Candidates are sometimes relevant, so I'd lean towards not hiding them either.
I don't know why either of these two (maintainers list or candiadtes) are under "Mainteiner's corner". I'd prefer them to be in the list of package features in the sidebar.
Having the "Edit" link or the title "Maintainer's corner" visible to anyone other than maintainers I find unfortunate. But that's a consequence of how the ancient authentication mechanism prompts you to go about it, I guess: there's no explicit Login button (easily available?) and the easiest way to log in is to click the Edit link.
Now is the time to ask you @MangoIV to provide a screenshot of what it means to be "hidden" in your patch, because I'm bad at compiling HTML in my head, and a mockup would help me to decide whether I prefer "Edit" to be "hidden". In any case, if it's pretty much one link at this point, there's no reason to split hairs over this: I'd just go with what Gershom suggests.
Ah perfect, that’s a good helper to enforce that decision. I’ll also put up a screenshot when I get around to it. But I think both of your arguments are fair!
I'm still not entirely happy with how this looks, especially on pages with very large module lists. I think the README should come first and then both the modules and the rest should be side bars? But that's also not idea because that requires a lot of width.
Thanks for the screenshots!
maybe we need tabs like Rust’s crates.io?..
They also have less busy right sidebar with metadata, which seems like a good idea. Dependencies, one of the bigger fields in our sidebar, go in a tab with their design.
E.g. https://crates.io/crates/syn
I keep getting back to thinking about this proposal. I'd love some version of it merged. However incremental, this would be an improvement, I believe. @gbaz @MangoIV is there a chance we can get back to this?
@MangoIV can you update the PR description to state what's the current content of it? Also, fewer headers in there could help (there's virtually no text between the headers). In general, I'd suggest split out refactorings like "build in a tiny bit of semantic HTML" from actual changes (as separate PRs). It'd make it easier to review, and the result will have a higher chance of merging.