hackage-server icon indicating copy to clipboard operation
hackage-server copied to clipboard
verified publisher icon haskell

Hackage shows non-public, internal libraries

Open phadej opened this issue 1 year ago • 2 comments

This is wrong, please don't.

image

  • https://hackage.haskell.org/package/puresat
  • https://hackage.haskell.org/package/haskell-ci
  • https://hackage.haskell.org/package/attoparsec

phadej avatar Nov 23 '24 12:11 phadej

I second that and want to expand. There seems to be two problems currently.

  1. If the visibility setting is not specified for an internal library, the docs for it are rendered as if it's public. However the Cabal docs state that internal libraries are private by default. See "attoparsec" for example.

  2. If visibility is explicitly set to private the docs don't get rendered, but the contents of the internal library still get listed at the landing page of the package. See "hasql" for example.

I believe that in both cases Hackage should just ignore the internal packages and neither list or generate docs for them.

nikita-volkov avatar Dec 02 '24 20:12 nikita-volkov

This feature was introduced by @414owen in https://github.com/haskell/hackage-server/pull/1279 -- maybe they'd be open to a followup PR? Patches from others also welcome.

gbaz avatar Dec 03 '24 00:12 gbaz

@gbaz Please see the PR with a fix: https://github.com/haskell/hackage-server/pull/1437

nikita-volkov avatar Oct 10 '25 09:10 nikita-volkov

Fixed in #1437. Note that it hasn't been deployed to the public Hackage yet.

ysangkok avatar Oct 16 '25 18:10 ysangkok