hackage-server icon indicating copy to clipboard operation
hackage-server copied to clipboard

style: Apply input padding and color tweaks

Open 414owen opened this issue 2 years ago • 2 comments

This adds some padding to inputs, giving them a bit of a sense of space.

  • input background: light grey
  • text input background: light purple

The only difference between light and dark themes is that the border is removed in dark mode.

I opted for colours that work well in light and dark mode, to keep things simple.

I think the padding makes the inputs considerably less cramped, but style is subjective, so any input is welcome.

Are there any other pages with inputs that might have changed? If so, let me know and I'll screenshot the differences.

Before

Firefox - dark theme

Screenshot from 2024-01-03 12-45-22 Screenshot from 2024-01-03 13-14-24 Screenshot from 2024-01-03 13-16-30

Chromium - light theme

Screenshot from 2024-01-03 12-58-03 Screenshot from 2024-01-03 13-14-00 Screenshot from 2024-01-03 13-16-48

After

Firefox - dark theme

Screenshot from 2024-01-03 12-45-10 Screenshot from 2024-01-03 13-14-12 Screenshot from 2024-01-03 13-16-21

Chromium - light theme

Screenshot from 2024-01-03 12-57-53 Screenshot from 2024-01-03 13-13-53 Screenshot from 2024-01-03 13-16-42

414owen avatar Jan 03 '24 12:01 414owen

Looks good to me, thanks! But I am not a reviewer

peterbecich avatar Jan 20 '24 08:01 peterbecich

Thanks for taking the time to improve Hackage.

I'd prefer to not change the form input background color in the light theme. Seeing the pink hue, I'd interpret as meaning something, while it seems like it actually means nothing. White input elements are common around the web, red hues are usually used when validation failed. I'd be curious to hear others on this too.

I don't like the white input elements on the dark theme though, there is too much contrast. I'd prefer if we just started out fixing that issue first. (I'd suggest making them just slightly brighter than the background)

I don't mind the padding, though.

ysangkok avatar Jan 22 '24 22:01 ysangkok

good point @ysangkok about the pink hue, I hadn't thought of that.

@414owen , would you remove the color changes or split into a different PR and keep the other improvements in this PR?

peterbecich avatar Jun 21 '24 06:06 peterbecich

@peterbecich Sure thing, I've removed the purple tinge from the text inputs :)

Screenshot 2024-06-24 at 22 57 28

414owen avatar Jun 24 '24 22:06 414owen

@ysangkok please review

peterbecich avatar Jun 25 '24 06:06 peterbecich