hackage-server icon indicating copy to clipboard operation
hackage-server copied to clipboard

Published 20 hours ago • verified publisher icon haskell

support for `prefers-color-scheme`

Open peterbecich opened this issue 3 years ago • 5 comments

Closes https://github.com/haskell/hackage-server/issues/1007 https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Some of the foreground and background colors are simply swapped. ~href colors should probably be brightened.~ Opinions appreciated. Preview: https://github.com/haskell/hackage-server/pull/1008#issuecomment-1138132085

peterbecich avatar Feb 13 '22 22:02 peterbecich

Feedback appreciated

I think the default mode is unchanged.

Viewing in Firefox: Screenshot 2022-05-25 at 21-04-49 Introduction Hackage Screenshot 2022-05-25 at 21-04-20 Browse and search packages Hackage

How do I populate the module documentation / function definitions? Edit: question here https://discourse.haskell.org/t/populate-module-documentation-in-local-instance-of-hackage-server/4630 i.e.

TwoCaptcha

    TwoCaptcha.Captcha
    Internal
        TwoCaptcha.Internal.Client
        Types
 ...

I should check the function definitions look okay.

Screenshot 2022-05-25 at 21-04-35 2captcha

peterbecich avatar May 26 '22 04:05 peterbecich

Here is the Paginator Screenshot 2022-05-25 at 23-17-06 Browse and search packages Hackage Screenshot 2022-05-25 at 23-06-13 Browse and search packages Hackage

peterbecich avatar May 26 '22 06:05 peterbecich

I like the colors and everything is clearly readable.

andreasabel avatar May 27 '22 12:05 andreasabel

One thing I've not checked are any function definitions like: Screenshot 2022-05-28 at 00-25-54 Data Vector Generic

because on my local instance of Hackage Server these are unpopulated: func_definitions

Can you tell me how to populate these?

peterbecich avatar May 28 '22 07:05 peterbecich

Looks like there is more to do

The Haddock exists now Screenshot 2022-06-03 at 00-02-43 zlib

It must use a different set of style sheets Screenshot 2022-06-03 at 00-02-31 Codec Compression GZip

peterbecich avatar Jun 03 '22 07:06 peterbecich

For the most part people seem really happy about this!

However, a comment points out a few missed spots -- quickjump, and also the (new) revdeps feature. A pr to fix these up would be most welcome. https://discourse.haskell.org/t/new-hackage-server-features/2621/28

gbaz avatar Jan 06 '23 21:01 gbaz

oh some of the banners too https://twitter.com/qnikst/status/1611392984700055552

gbaz avatar Jan 06 '23 22:01 gbaz

Whoops, I'll prioritize an opt-in button, will try to get this done today

peterbecich avatar Jan 07 '23 00:01 peterbecich

In my opinion, an opt-out is not so important, compared to just fixing up the maybe three cases discovered so far that need to be handled. Luckily as this is just a CSS change, deploying it will be safe and simple.

gbaz avatar Jan 07 '23 00:01 gbaz

Okay, will do

peterbecich avatar Jan 07 '23 00:01 peterbecich

please review https://github.com/haskell/hackage-server/pull/1162

I need to fix the Quick Jump separately, WIP: https://github.com/haskell/hackage-server/pull/1163

peterbecich avatar Jan 07 '23 01:01 peterbecich