ghc-events icon indicating copy to clipboard operation
ghc-events copied to clipboard

Fix type of ProfSampleCostCentre.profCapSet event field

Open TeofilC opened this issue 1 year ago • 1 comments

This is a CapNo rather than a CapSet. The event stores this as an Int32, but CapNo is an Int16. So we need to do some conversions.

Resolves #84

NB: this is a breaking change, as we change the type and name of this field

TeofilC avatar Aug 09 '24 17:08 TeofilC

Maybe a sentence in the changelog? It's not entirely defunct, it seems.

Mikolaj avatar Aug 09 '24 18:08 Mikolaj

I've added a changelog entry now

TeofilC avatar Oct 02 '24 09:10 TeofilC

Merged. Thank you, @TeofilC!

Mikolaj avatar Oct 05 '24 08:10 Mikolaj