criterion icon indicating copy to clipboard operation
criterion copied to clipboard

allow rendering comparison chart split by top level bgroup

Open cartazio opened this issue 10 years ago • 10 comments

heres an example of splitting the top level chart vs the current one

https://bitbucket.org/carter/multicriterion-templates/src/b1c1b808b71c?at=master is the current repo for this.

I'm not necessarily saying "merge this in", but might at least be worth having a curated "plugins.md" / "addons.md" / "moretools.md" list or something that is centrally curated

cartazio avatar Sep 11 '14 16:09 cartazio

the main point is the current default rendering doesnt interact well with there being a large dynamic range of runtimes in a single suite

cartazio avatar Sep 11 '14 16:09 cartazio

I can turn this template into a PR if theres support for it

cartazio avatar Sep 11 '14 18:09 cartazio

This would be a huge benefit to me. Often times I run multiple groups of benchmarks, with each group having wildly different average times (often multiple orders of magnitude). Having each group displayed separately would give more immediately consumable information.

snoyberg avatar Sep 11 '14 18:09 snoyberg

Agreed, having the ability to split the bgroups readily available would be neat, even if it's not the default and if you have to toggle some command-line flag to get it -- the point being that it would be easy to enable.

alpmestan avatar Sep 12 '14 07:09 alpmestan

I'm already using @cartazio's version for a couple of my projects.

erikd avatar Sep 16 '14 01:09 erikd

I'd also like this -- @cartazio could you turn it into a PR?

rrnewton avatar Aug 16 '16 14:08 rrnewton

I've been meaning to de bit rot this for a while, and make it more performant at rendering. Currently it has some gnarly / huge quadratic blowups ok large data sets / bench suite rendering

I'll be happy to turn it into a PR if you mean that you're the primary maintainer now and can Shepard it being merged in, or something like that.

On Tuesday, August 16, 2016, Ryan Newton [email protected] wrote:

I'd also like this -- @cartazio https://github.com/cartazio could you turn it into a PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bos/criterion/issues/62#issuecomment-240117652, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAQwiyFksrRpRGb7SuLjsHn0_SxD9i9ks5qgcgPgaJpZM4ChFCv .

cartazio avatar Aug 16 '16 16:08 cartazio

Yes, exactly, I'm a co-maintainer and we're trying to catch up on outstanding issues.

rrnewton avatar Aug 16 '16 16:08 rrnewton

Sweet. Would an updated template in the style of this ticket but saner rendering perf be a candidate for being the new default if it's intelligible ?

On Tuesday, August 16, 2016, Ryan Newton [email protected] wrote:

Yes, exactly, I'm a co-maintainer and we're trying to catch up on outstanding issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bos/criterion/issues/62#issuecomment-240164366, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAQwvnzoWmjwGdVeMXSxmAnu9QIdzrKks5qgeqAgaJpZM4ChFCv .

cartazio avatar Aug 16 '16 17:08 cartazio

@rrnewton this is on my todo queue now. @EleanorWhite and I are going to see about maybe finishing it up :)

cartazio avatar Jan 05 '17 22:01 cartazio