containers icon indicating copy to clipboard operation
containers copied to clipboard

Unnecessary CPP and C header in `Data.Map.Internal.Debug.html`?

Open Vlix opened this issue 2 years ago • 1 comments

I see containers.h being #included in almost every module, which is probably the point, but is this just a specific choice: "include it everywhere, if we ever need it it'll be in scope and if we don't the compiler will just ignore it"? Or is this an oversight and is it better to limit the amount of CPP pragmas and inclusion of C headers?

Asking in case someone (me?) might want to clean it up, or that this is intentional and should stay this way.

Vlix avatar Aug 24 '23 10:08 Vlix

Looking at the history, the header used to define some widely used macros: https://github.com/haskell/containers/blob/dade1658363660395c0f00b951cfcd71acee5b8c/include/containers.h

Since that is no longer the case, I'm all for cleaning up the #includes and {-# LANGUAGE CPP #-} where it's not used.
PRs welcome.

meooow25 avatar Mar 22 '25 10:03 meooow25