cabal
cabal copied to clipboard
Draft: Add support for building profiled dynamic way
Draft: here for CI at the moment
I require the version to be bumped to 3.13 before this can be finished.
That's
- #9897
The test fails on 8.6.5 because of this GHC bug (fixed in 2018): e400b9babdcf11669f963aeec20078fe7ccfca0d
Can someone please review this patch? I would like to get it off my plate as I have been working on it for quite a while.
I made two recent improvements.
- Better handling of -dynamic-too
- Enforce that Cabal >3.13 constraint applies to all setups if profiling dynamic is used anywhere (this is conservative).
I feel the code to handle "way" keeps getting more and more complex. Is there any way we can reduce this complexity?
E.g. do we really need to know what GHC support in what situation? can we instead just do what the user wants and leave GHC to deal with it? Otherwise we end up replicating a bunch of logic that belongs to the compiler.
Is there a particular bit of code which you find too complicated? I have just extended how cabal-install has already worked in relation to ways (and actually simplified a lot of the calculations about which ways are built and needed).
I have fixed the issue now about the cabal spec version, that is a good point.
@andreabedini: was your concern answered satisfactorily? If so, could you mark it in the system so that mergify knows to proceed? Thank you!
@Mikolaj My comment about the complexity was not essential to the request for changes. My only request was to guard the fields behind cabalSpecVersion, which has been acted upon. Thanks @mpickering.