cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Define BuildTarget in new BuildTarget.Types module

Open sheaf opened this issue 2 years ago • 3 comments

This change means that we can refer to BuildTarget in Cabal error constructors. (Attempting to do so before this change would cause cyclic imports.)

sheaf avatar Nov 24 '23 13:11 sheaf

Sub component targets had never been implemented and that is mostly dead-code. I think we should consider removing this feature, including from cabal-install. I had PR that did that but it got bitrotten by the advent of fourmolu.

andreabedini avatar Nov 27 '23 13:11 andreabedini

Sub component targets had never been implemented and that is mostly dead-code. I think we should consider removing this feature, including from cabal-install. I had PR that did that but it got bitrotten by the advent of fourmolu.

Ah yes, I see, that was #8966.

I'm not sure we will end up needing the changes in this PR in the end, so I'm happy to park it for the time being.

sheaf avatar Nov 29 '23 10:11 sheaf

I think this refactor still makes sense, but nothing important depends on it right now.

sheaf avatar Mar 05 '24 08:03 sheaf