cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Preserve the relative paths of license files

Open L-TChen opened this issue 2 years ago • 6 comments

As suggested in #9172, I propose an independent PR to resolve #9184, which removes the use of takeFileName while copying license files.

It also moves the definition of paths of copied license files to the module Distribution.Simple.BuildPaths, as other packages might use this definition to determine the location of license files.


Template Α: This PR modifies cabal behaviour

Include the following checklist in your PR:

Bonus points for added automated tests!

L-TChen avatar Sep 12 '23 05:09 L-TChen

The Validate thing is a bug in the new unix package. It's been marked uninstallable until a new release is made, so CI should work now.

geekosaur avatar Sep 12 '23 15:09 geekosaur

Could there be a test demonstrating the new behavior?

I'd love to, but I am not able to run cabal-tests in the package cabal-testsuite locally, even though I have followed the instruction documented in cabal-testsuite/README.md. It always complains

: cannot satisfy -package-id Cabal-3.11.0.0-inplace

Any hint?

L-TChen avatar Sep 20 '23 05:09 L-TChen

@L-TChen For me, the instructions work:

cabal build all
cabal run cabal-testsuite:cabal-tests -- --with-cabal=cabal cabal-testsuite/PackageTests/TestOptions/setup.test.hs

andreasabel avatar Sep 26 '23 14:09 andreasabel

@L-TChen did you manage to compile it? Can we help?

ffaf1 avatar Dec 15 '23 14:12 ffaf1

@L-TChen did you manage to compile it? Can we help?

Yes, thanks for asking. I managed to run the test suite locally, but I just did not have the time to complete it.

L-TChen avatar Dec 15 '23 16:12 L-TChen

Is this still pending a test?

gbaz avatar Oct 10 '24 17:10 gbaz

@L-TChen If you need a hand with writing tests, I can do it!

ffaf1 avatar Jan 16 '25 18:01 ffaf1

@L-TChen: ping! ping! we want to help! :)

Mikolaj avatar Apr 24 '25 17:04 Mikolaj