cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Allow offline bootstrapping of cabal-install

Open sheaf opened this issue 3 years ago • 1 comments

This ports to cabal-install the offline bootstrapping logic which was introduced for Hadrian in GHC MR !6315.

This adds a "fetch" command to the bootstrap script, which fetches all the dependency tarballs from Hackage, to be used in an offline build. See bootstrap/README.md for further information.

I tested this locally but would appreciate further testing, perhaps changing the bootstrap CI scripts to separately fetch the archive and then build with the archives.


Please include the following checklist in your PR:

sheaf avatar Aug 12 '22 12:08 sheaf

Thanks a lot. Good point about "changing the bootstrap CI scripts to separately fetch the archive and then build with the archives". That would tick the "test" box required to accept the PR. For the "changelog" box, it's enough to include a tiny file describing the change, as in all other PRs.

Mikolaj avatar Aug 12 '22 14:08 Mikolaj

Let me rebase to include a workaround to our CI instability and fix the tests.

Mikolaj avatar Aug 16 '22 22:08 Mikolaj

@mergify rebase

Mikolaj avatar Aug 16 '22 22:08 Mikolaj

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 16 '22 22:08 mergify[bot]

  • Added a changelog entry (to cabal-install-3.8.0.20220526.md, let me know if it should be somewhere else).
  • Made the bootstrap test use this new functionality.
  • Addressed review comments.

sheaf avatar Aug 17 '22 09:08 sheaf

Added a changelog entry (to cabal-install-3.8.0.20220526.md, let me know if it should be somewhere else)

see https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#changelog

fgaz avatar Aug 17 '22 09:08 fgaz

Updated the changelog, grazie Francesco.

sheaf avatar Aug 17 '22 11:08 sheaf

Could we get this merged?

sheaf avatar Sep 13 '22 10:09 sheaf

I mean, after the conflict is resolved. :)

Mikolaj avatar Sep 15 '22 15:09 Mikolaj