cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Expose BuildFlags and ClientHaddockFlags

Open kokobd opened this issue 3 years ago • 11 comments

This will fix #8351


Please include the following checklist in your PR:

kokobd avatar Aug 10 '22 09:08 kokobd

FYI: CI is borked right now (#8356), so the error probably has nothing to do with this PR.

Mikolaj avatar Aug 10 '22 13:08 Mikolaj

Let me rebase to see if the recent CI workaround unblocks your testing.

Mikolaj avatar Aug 11 '22 10:08 Mikolaj

@mergify rebase

Mikolaj avatar Aug 11 '22 10:08 Mikolaj

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 11 '22 10:08 mergify[bot]

This might be ready in my mind.

kokobd avatar Aug 12 '22 06:08 kokobd

Splendid. Let's wait for the mandatory second review.

Mikolaj avatar Aug 12 '22 14:08 Mikolaj

Someone has to apply the squash+merge_me label now.

ulysses4ever avatar Aug 12 '22 16:08 ulysses4ever

@kokobd: I've granted you Triage authorization so that you can set the squash+merge_me (or merge_me) label on this PR and behold the mergifyIO magic (which takes 2 todays to unfold, in order to give people time to comment).

Mikolaj avatar Aug 12 '22 20:08 Mikolaj

CI seems to be broken. Let me rebase to verify if our recent partial fixes help.

Mikolaj avatar Aug 15 '22 09:08 Mikolaj

@mergify rebase

Mikolaj avatar Aug 15 '22 09:08 Mikolaj

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 15 '22 09:08 mergify[bot]

what a strange error: Screen Shot 2022-08-16 at 10 06 23

kokobd avatar Aug 16 '22 02:08 kokobd

what a strange error:

Yes, I think something broke in our CI infrastructure. Due to that mergify can't merge automatically, so let me merge manually.

Mikolaj avatar Aug 16 '22 06:08 Mikolaj

@mergify rebase

Mikolaj avatar Aug 16 '22 06:08 Mikolaj

rebase

☑️ Nothing to do

  • [X] -closed [:pushpin: rebase requirement]
  • [ ] any of:
    • [ ] #commits-behind>0 [:pushpin: rebase requirement]
    • [ ] -linear-history [:pushpin: rebase requirement]

mergify[bot] avatar Aug 16 '22 06:08 mergify[bot]

@kokobd: thank you!

Mikolaj avatar Aug 16 '22 06:08 Mikolaj

@mergify backport 3.8

Then let's backport this too, so that cabal-hoogle can work with cabal 3.8

kokobd avatar Sep 13 '22 14:09 kokobd

backport 3.8

✅ Backports have been created

mergify[bot] avatar Sep 13 '22 14:09 mergify[bot]