cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Published 20 hours ago • verified publisher icon haskell

testsuite: remove file generated by autoheader

Open andreasabel opened this issue 3 years ago • 8 comments

Testsuite: remove file generated by autoheader.

After running the cabal-testsuite, I found changes in this file, so I suppose it is a generated file and can (and should) be removed from the source tree.

It actually says so:

/* include/HsZlibConfig.h.in.  Generated from configure.ac by autoheader.  */

andreasabel avatar Sep 02 '21 07:09 andreasabel

Ok, now CI fails, i have to investigate...

andreasabel avatar Sep 02 '21 08:09 andreasabel

@mergify rebase

ulysses4ever avatar Aug 07 '22 20:08 ulysses4ever

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 07 '22 20:08 mergify[bot]

I wonder if it fails because the include directory will cease to exist after this change (it may seem like the change only removes the file but it was the only one in that dir, and git doesn’t like empty dirs…).

ulysses4ever avatar Aug 08 '22 00:08 ulysses4ever

That was it.

ulysses4ever avatar Aug 08 '22 01:08 ulysses4ever

@andreasabel, are you ready to mergify-merge?

Mikolaj avatar Aug 08 '22 10:08 Mikolaj

Let me step in and add the label...

Mikolaj avatar Aug 09 '22 21:08 Mikolaj

Thanks, @ulysses4ever, for finishing this!

andreasabel avatar Aug 11 '22 16:08 andreasabel

@ulysses4ever : Here, it claims that I forced-pushed. ;-)

andreasabel avatar Aug 18 '22 09:08 andreasabel