cabal
cabal copied to clipboard
Recognise SetupHooks.hs
Closes #11349
cabal check now recognises SetupHooks.hs as a valid setup script.
- [x] Patches conform to the coding conventions.
- [x] Any changes that could be relevant to users have been recorded in the changelog.
- [x] Is the change significant? If so, remember to add
significance: significantin the changelog file.
- [x] Is the change significant? If so, remember to add
- [x] The documentation has been updated, if necessary.
- [x] Manual QA notes have been included.
- [x] Tests have been added. (Ask for help if you donβt know how to write them! Ask for an exemption if tests are too complex for too little coverage!)
QA NOTES
Download the repro in #11349, run cabal check.
Does this need backport? I think so, since it influences Hackage behaviour.
Merge Queue Status
β The pull request has been merged at e71de2b83749366ba0450ee14a8396edd72f32c5
This pull request spent 2 hours 6 minutes 58 seconds in the queue, including 1 hour 55 minutes 46 seconds running CI. The checks were run on draft #11361.
Required conditions to merge
-
#approved-reviews-by >= 2[π‘ GitHub branch protection]- [X] #11351
-
#changes-requested-reviews-by = 0[π‘ GitHub branch protection]- [X] #11351
-
#review-threads-unresolved = 0[π‘ GitHub branch protection]- [X] #11351
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = Doctest Cabal - [ ]
check-neutral = Doctest Cabal - [ ]
check-skipped = Doctest Cabal
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = Meta checks - [ ]
check-neutral = Meta checks - [ ]
check-skipped = Meta checks
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = docs/readthedocs.org:cabal - [ ]
check-neutral = docs/readthedocs.org:cabal - [ ]
check-skipped = docs/readthedocs.org:cabal
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = Validate post job - [ ]
check-neutral = Validate post job - [ ]
check-skipped = Validate post job
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = fourmolu - [ ]
check-neutral = fourmolu - [ ]
check-skipped = fourmolu
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = hlint - [ ]
check-neutral = hlint - [ ]
check-skipped = hlint
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = Bootstrap post job - [ ]
check-neutral = Bootstrap post job - [ ]
check-skipped = Bootstrap post job
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = whitespace - [ ]
check-neutral = whitespace - [ ]
check-skipped = whitespace
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = Check sdist post job - [ ]
check-neutral = Check sdist post job - [ ]
check-skipped = Check sdist post job
- [X]
- [X] any of [π‘ GitHub branch protection]:
- [X]
check-success = Changelogs - [ ]
check-neutral = Changelogs - [ ]
check-skipped = Changelogs
- [X]
@mergify backport 3.16
backport 3.16
β Backports have been created
-
#11362 Backport #11351: Recognise SetupHooks.hs has been created for branch
3.16