cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Recognise SetupHooks.hs

Open ffaf1 opened this issue 2 months ago β€’ 1 comments

Closes #11349 cabal check now recognises SetupHooks.hs as a valid setup script.

  • [x] Patches conform to the coding conventions.
  • [x] Any changes that could be relevant to users have been recorded in the changelog.
  • [x] The documentation has been updated, if necessary.
  • [x] Manual QA notes have been included.
  • [x] Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

QA NOTES

Download the repro in #11349, run cabal check.

ffaf1 avatar Dec 15 '25 17:12 ffaf1

Does this need backport? I think so, since it influences Hackage behaviour.

ffaf1 avatar Dec 15 '25 17:12 ffaf1

Merge Queue Status

βœ… The pull request has been merged at e71de2b83749366ba0450ee14a8396edd72f32c5

This pull request spent 2 hours 6 minutes 58 seconds in the queue, including 1 hour 55 minutes 46 seconds running CI. The checks were run on draft #11361.

Required conditions to merge
  • #approved-reviews-by >= 2 [πŸ›‘ GitHub branch protection]
    • [X] #11351
  • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
    • [X] #11351
  • #review-threads-unresolved = 0 [πŸ›‘ GitHub branch protection]
    • [X] #11351
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = Doctest Cabal
    • [ ] check-neutral = Doctest Cabal
    • [ ] check-skipped = Doctest Cabal
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = Meta checks
    • [ ] check-neutral = Meta checks
    • [ ] check-skipped = Meta checks
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = docs/readthedocs.org:cabal
    • [ ] check-neutral = docs/readthedocs.org:cabal
    • [ ] check-skipped = docs/readthedocs.org:cabal
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = Validate post job
    • [ ] check-neutral = Validate post job
    • [ ] check-skipped = Validate post job
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = fourmolu
    • [ ] check-neutral = fourmolu
    • [ ] check-skipped = fourmolu
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = hlint
    • [ ] check-neutral = hlint
    • [ ] check-skipped = hlint
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = Bootstrap post job
    • [ ] check-neutral = Bootstrap post job
    • [ ] check-skipped = Bootstrap post job
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = whitespace
    • [ ] check-neutral = whitespace
    • [ ] check-skipped = whitespace
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = Check sdist post job
    • [ ] check-neutral = Check sdist post job
    • [ ] check-skipped = Check sdist post job
  • [X] any of [πŸ›‘ GitHub branch protection]:
    • [X] check-success = Changelogs
    • [ ] check-neutral = Changelogs
    • [ ] check-skipped = Changelogs

mergify[bot] avatar Dec 17 '25 20:12 mergify[bot]

@mergify backport 3.16

ffaf1 avatar Dec 18 '25 07:12 ffaf1

backport 3.16

βœ… Backports have been created

mergify[bot] avatar Dec 18 '25 07:12 mergify[bot]