cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Remove hashable dependency

Open jaspervdj opened this issue 1 year ago • 3 comments

See #10140

  • [x] Patches conform to the coding conventions.
  • [ ] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

jaspervdj avatar Sep 05 '24 09:09 jaspervdj

Removing hashable from the test suite nerd-sniped me into writing a bit of whacky arbitrary machinery, but I think it's not necessarily worse than abusing hashable for this.

jaspervdj avatar Sep 05 '24 18:09 jaspervdj

I added some minimal comments to the code as well.

I'd hope for a smaller diff if we just had some of the compat code added to some sort of Prelude or Compat module

IMO, Distribution.Client.HashValue is this compat module. It just wasn't used in FileMonitor yet...

jaspervdj avatar Sep 06 '24 08:09 jaspervdj

IMO, Distribution.Client.HashValue is this compat module. It just wasn't used in FileMonitor yet...

Oh, that's good, thank you!

ulysses4ever avatar Sep 06 '24 13:09 ulysses4ever

This needs a manual rebase on top of master, sorry @jaspervdj. Do you have time for this or should we try to take care of it?

ulysses4ever avatar Nov 07 '24 01:11 ulysses4ever

Actually, this was trivial, don't worry. Should merge soon.

ulysses4ever avatar Nov 07 '24 02:11 ulysses4ever

@mergify backport 3.14

ulysses4ever avatar Nov 07 '24 15:11 ulysses4ever

backport 3.14

✅ Backports have been created

mergify[bot] avatar Nov 07 '24 15:11 mergify[bot]