cabal icon indicating copy to clipboard operation
cabal copied to clipboard

fix non-POSIX [[ ]]

Open geekosaur opened this issue 1 year ago • 1 comments

Otherwise CI prints validate.sh: 332: [[: not found and the line does nothing (but validate.sh continues to run), unless the system shell is ksh / bash / zsh. This may explain https://github.com/haskell/cabal/pull/10114#issuecomment-2178163927.

Please read Github PR Conventions and then fill in one of these two templates.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • [x] Patches conform to the coding conventions.
  • [x] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). —only indirectly

geekosaur avatar Jul 04 '24 01:07 geekosaur

Won't pass CI until #10172 lands.

geekosaur avatar Jul 04 '24 01:07 geekosaur

@mergify backport 3.12

geekosaur avatar Aug 30 '24 21:08 geekosaur

backport 3.12

✅ Backports have been created

mergify[bot] avatar Aug 30 '24 21:08 mergify[bot]