cabal icon indicating copy to clipboard operation
cabal copied to clipboard

cabal-testsuite.cabal: bump custom-setup bounds on Cabal(-syntax) after the release

Open ulysses4ever opened this issue 1 year ago • 3 comments

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • [x] Patches conform to the coding conventions.
  • [ ] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

ulysses4ever avatar Jul 03 '24 20:07 ulysses4ever

Huh, doctests and one quick job fail. Any ideas why?

ulysses4ever avatar Jul 03 '24 20:07 ulysses4ever

It looks like doctest and field syntax reference are still using cabal 3.10.3.0 (ghcup default?), whereas everything else is using 3.12.1.0.

geekosaur avatar Jul 03 '24 22:07 geekosaur

Great catch, thanks a lot! We should always say "latest" for cabal-install in ghcup configs.

ulysses4ever avatar Jul 03 '24 23:07 ulysses4ever

It seems to me the bug here is that we specify cabal-version: latest in setup-haskell. My opinion is that it's better to pin this to something specific and update it in an orderly way (otherwise you get these situations where CI is completely broken and blocking patches).

mpickering avatar Jul 04 '24 10:07 mpickering

I pushed another commit to fix the quick jobs.

mpickering avatar Jul 04 '24 10:07 mpickering

thanks everyone for pushing it over the line! Sadly, the holiday caught me off-guard and I couldn't finish it in a timely manner.

ulysses4ever avatar Jul 04 '24 19:07 ulysses4ever

@mergify backport 3.12

ulysses4ever avatar Jul 04 '24 19:07 ulysses4ever

backport 3.12

✅ Backports have been created

mergify[bot] avatar Jul 04 '24 19:07 mergify[bot]