cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Bootstrap plans still contain hashable-1.4.6.0 with +arch-native

Open TerrorJack opened this issue 1 year ago • 6 comments

Before the new release goes out, you might also want to update bootstrap json plans to ensure hashable-1.4.6.0 is not contained in the bootstrap plans, maybe also bumping the hashable lower bound?

Related: #9885 #10142

TerrorJack avatar Jun 24 '24 19:06 TerrorJack

Bootstrap plans aren't part of the release.

geekosaur avatar Jun 24 '24 19:06 geekosaur

More to the point, we've punted on bootstrap plans for 9.10.1 because we want to release before hackage-server is likely to release a compatible version, so bootstrap is going to be hobbled anyway.

geekosaur avatar Jun 24 '24 19:06 geekosaur

I think it's fine if bootstraps don't support the newest GHC. The original purpose was to bootstrap to new architectures and using the newest GHC is only asking for trouble (unless it's the only one supporting the architecture). Similarly, Linux distributions never use the newest GHC.

BTW, is hashable-1.4.6.0 actually a part of any of the existing boostrap plans on branch master? It can't be, I guess?

Mikolaj avatar Jun 24 '24 21:06 Mikolaj

Bootstrap plans aren't part of the release.

Of course, but bootstrap plans infected with a bad revision of hashable will still bite their consumers hard (e.g. distro packagers) so it's still good to correct this particular mistake IMHO

BTW, is hashable-1.4.6.0 actually a part of any of the existing boostrap plans on branch master?

https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.8.2.json#L214 https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.6.4.json#L210 https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.4.8.json#L240 https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.2.8.json#L250 https://github.com/haskell/cabal/blob/master/bootstrap/linux-9.0.2.json#L280 https://github.com/haskell/cabal/blob/master/bootstrap/linux-8.10.7.json#L280

TerrorJack avatar Jun 24 '24 21:06 TerrorJack

A bunch of hashable refs in the bootstrap jsons on both 3.12 and master have +arch-native.

hilfy «cabal:master» Z$ grep -A2 hashable bootstrap/*.json
bootstrap/linux-8.10.7.json:      "component": "lib:hashable",
bootstrap/linux-8.10.7.json-      "flags": [
bootstrap/linux-8.10.7.json-        "+arch-native",
--
bootstrap/linux-8.10.7.json:      "package": "hashable",
bootstrap/linux-8.10.7.json-      "revision": 0,
bootstrap/linux-8.10.7.json-      "source": "hackage",
--
bootstrap/linux-9.0.2.json:      "component": "lib:hashable",
bootstrap/linux-9.0.2.json-      "flags": [
bootstrap/linux-9.0.2.json-        "+arch-native",
--
bootstrap/linux-9.0.2.json:      "package": "hashable",
bootstrap/linux-9.0.2.json-      "revision": 0,
bootstrap/linux-9.0.2.json-      "source": "hackage",
--
bootstrap/linux-9.2.8.json:      "component": "lib:hashable",
bootstrap/linux-9.2.8.json-      "flags": [
bootstrap/linux-9.2.8.json-        "+arch-native",
--
bootstrap/linux-9.2.8.json:      "package": "hashable",
bootstrap/linux-9.2.8.json-      "revision": 0,
bootstrap/linux-9.2.8.json-      "source": "hackage",
--
bootstrap/linux-9.4.8.json:      "component": "lib:hashable",
bootstrap/linux-9.4.8.json-      "flags": [
bootstrap/linux-9.4.8.json-        "+arch-native",
--
bootstrap/linux-9.4.8.json:      "package": "hashable",
bootstrap/linux-9.4.8.json-      "revision": 0,
bootstrap/linux-9.4.8.json-      "source": "hackage",
--
bootstrap/linux-9.6.4.json:      "component": "lib:hashable",
bootstrap/linux-9.6.4.json-      "flags": [
bootstrap/linux-9.6.4.json-        "+arch-native",
--
bootstrap/linux-9.6.4.json:      "package": "hashable",
bootstrap/linux-9.6.4.json-      "revision": 0,
bootstrap/linux-9.6.4.json-      "source": "hackage",
--
bootstrap/linux-9.8.2.json:      "component": "lib:hashable",
bootstrap/linux-9.8.2.json-      "flags": [
bootstrap/linux-9.8.2.json-        "+arch-native",
--
bootstrap/linux-9.8.2.json:      "package": "hashable",
bootstrap/linux-9.8.2.json-      "revision": 0,
bootstrap/linux-9.8.2.json-      "source": "hackage",
hilfy «cabal:master» Z$ _

geekosaur avatar Jun 24 '24 21:06 geekosaur

Wow, well spotted. Surprising that it's so many of them.

Mikolaj avatar Jun 24 '24 22:06 Mikolaj

Interestingly, GitHub didn't close this issue despite recognizing the above merge that fixed this. Closing.

geekosaur avatar Aug 25 '24 21:08 geekosaur