aeson icon indicating copy to clipboard operation
aeson copied to clipboard

Mispellings across code

Open Benjamin-McRae-Tracsis opened this issue 1 year ago • 4 comments

unespected is a spelling error in at least 4 places I can see, plus tests.

Here is an example: https://github.com/haskell/aeson/blob/c93d60d82388c184a9cf240f016a728c9d0e758f/src/Data/Aeson/Decoding/ByteString.hs#L164C19-L164C29

It would be good to remove such spelling errors.

Benjamin-McRae-Tracsis avatar Sep 06 '24 16:09 Benjamin-McRae-Tracsis

You could use https://github.com/crate-ci/typos. It works surprisingly well!

ad-si avatar Sep 12 '24 22:09 ad-si

Hey, i would like to work on this if it is open to work.

dhruvdabhi101 avatar Jan 25 '25 20:01 dhruvdabhi101

Looks like someone was fixing it in #1081 before I even made this issue. I assume that @phadej would prefer to merge that than make a new PR.

L0neGamer avatar Jan 26 '25 08:01 L0neGamer

Yes, but we are careful not to change error messages in minor releases, as something (usually tests) may break somewhere. But alone spelling errors don't justify a major release, so I'm stalling on this issue.

phadej avatar Jan 26 '25 14:01 phadej