HTTP icon indicating copy to clipboard operation
HTTP copied to clipboard

Improper encoding of reserved characters

Open ttuegel opened this issue 9 years ago • 1 comments

This was originally reported as a Cabal bug, but I believe it belongs here:

The value of HTTP_PROXY has as format http://user:pass@host:80/

In the password special characters can occur, like @ and !. According to wiki (http://en.wikipedia.org/wiki/Percent-escape) these characters must be percent-encoded, like %40 and %21.

Cabal doesn't accept percent-encoded characters. And cabal errs on these characters (if password is a@b, Cabal doesn't look to the right site, but >probably to "b@host:80" (error message is not clear enough to be certain)

ttuegel avatar Apr 23 '15 23:04 ttuegel

Sounds plausible - if you can supply a fix that'd be great, otherwise I'll take a look but no guarantees as to when I'm afraid.

It'd be nice to have a test but I don't see any Haskell HTTP proxies that support authentication around so that's probably not feasible.

hsenag avatar Apr 24 '15 06:04 hsenag