servant icon indicating copy to clipboard operation
servant copied to clipboard

Published 20 hours ago • verified publisher icon haskell-servant

QueryParamForm Combinator

Open isairz opened this issue 7 years ago • 4 comments

#728

type MyApi = "book" :> QueryParamForm BookSearchParams :> Get '[JSON] [Book]

This is my first pull request in servant. Please feel free to review my commits 😃

  • [x] Add API
  • [x] instance and test for servant-server
  • [ ] instance and test for servant-client
  • [ ] instance and test for servant-doc
  • [ ] instance and test for servant-foreign

isairz avatar Apr 10 '17 16:04 isairz

Also, I don't see any changes for servant-client, for that you should symmetrically use ToForm.

fizruk avatar Apr 12 '17 10:04 fizruk

@fizruk the servant-client interpretation is still not ticked in the first comment in this issue :) I agree with fizruk's feedback, lacking the time to do a proper review but this is a good start! I'll review when it's all ready.

alpmestan avatar Apr 12 '17 10:04 alpmestan

@isairz are you going to work on this soon or should we take over?

fizruk avatar Jul 07 '17 10:07 fizruk

@fizruk Sorry, I was so busy and did not care. I will work on this soon.

isairz avatar Jul 10 '17 02:07 isairz