servant icon indicating copy to clipboard operation
servant copied to clipboard

Add MonadCatch and MonadMask instances to RouteResultT and DelayedIO

Open tchoutri opened this issue 6 months ago • 3 comments

Fix #1829

tchoutri avatar Jun 23 '25 13:06 tchoutri

@ysangkok @fisx I'd appreciate a review :)

tchoutri avatar Jul 17 '25 12:07 tchoutri

@ysangkok I'm open to suggestions for the test, my imagination is failing me.

tchoutri avatar Aug 13 '25 10:08 tchoutri

The reason I asked for the tests is because I don't have much experience with exception handling and masking in Haskell, so I can't really imagine what the code that could be broken by this would look like. The test would help explain that to me. But I wouldn't oppose to just optimistically merging this if you are reasonably confident that it is an improvement.

ysangkok avatar Oct 06 '25 16:10 ysangkok