servant icon indicating copy to clipboard operation
servant copied to clipboard

pick up PR for named routes cookbook again

Open MangoIV opened this issue 1 year ago • 10 comments

This PR is supposed to pick up the great work started in https://github.com/haskell-servant/servant/pull/1542 and rebase on current changes as well as apply fixes suggested by the reviewers, potentially also addressing new change requests.

MangoIV avatar Mar 07 '24 20:03 MangoIV

Thank you very much @MangoIV for this work! Reading the PR content, I feel like we ought to merge the NamedRoutes and Generics cookbooks together, under the NamedRoutes name.

tchoutri avatar Mar 07 '24 21:03 tchoutri

that's a good idea, I will do that then :)

MangoIV avatar Mar 07 '24 22:03 MangoIV

@MangoIV Are you still planning to do this?

ysangkok avatar Apr 21 '24 21:04 ysangkok

I am. I think we’re blocked by servant-qc (release, I have updated it) but I don’t know, let me check; will get to it this week perhaps ;)

MangoIV avatar Apr 21 '24 21:04 MangoIV

@MangoIV You may rebase your PR on top of master now, I've integrated servant-quickcheck in the monorepo.

tchoutri avatar Apr 22 '24 15:04 tchoutri

Lovely thank you <3

MangoIV avatar Apr 22 '24 15:04 MangoIV

Any news/blockers here regarding the merge? I also find this very valuable.

tfc avatar May 05 '24 09:05 tfc

@tfc yes, Mango still has to merge the two cookbooks. :)

tchoutri avatar May 05 '24 09:05 tchoutri

I have basically dropped the entire generic cookbook in favour of named routes, afaict I have transported all the information that didn't already occur in named routes but I would appreciate a thorough review to confirm.

MangoIV avatar May 20 '24 16:05 MangoIV

@ysangkok i still have a couple of failures sorry, I should mark it as draft again

MangoIV avatar May 22 '24 22:05 MangoIV

What's left to do here? The build errors have disappeared

googleson78 avatar Jan 27 '25 15:01 googleson78

@ysangkok reminder you wanted to click the button <3

Thanks everyone for the patience.

MangoIV avatar Feb 18 '25 07:02 MangoIV

@tchoutri Do you think we could deploy the documentation from master? I still don't see this listed on https://docs.servant.dev/en/stable/cookbook/index.html

ysangkok avatar May 09 '25 21:05 ysangkok

@ysangkok look at your URL, you're on stable. Check out the master branch: https://docs.servant.dev/en/master/cookbook/named-routes/NamedRoutes.html

tchoutri avatar May 10 '25 09:05 tchoutri