mafia
mafia copied to clipboard
Add `submodule-add` command
When adding package whatever
at lib/whatever
it would then check whatever
's dependencies and recursively add them as well.
@erikd i've also not been able to find docs for how i can depend on other repos... been trying to dig that up since you mentioned it
The way we currently do it is with git:
mkdir -p lib
git submodule add lib/whatever https://github.com/someone/whatever
and it should just all work.
Spoke to @jystic about this at lunch. He's not (yet) convinced this is a good idea.
The Pros:
- The
submodule
command will be listed in the mafia help output making it easily discoverable. - We can add both
submodule add
andsubmodule rm
, the second of which is a glaring omission in thegit submodule
command.
The Cons:
- Ties mafia to git (but no more so that is already the case).
It took me 10 minutes to figure out that git add is how I update what the submodule ref. And that in contrast git submodule update resets that child repo.
I am not an outlier in my git weakness, and I'm probably more competent than it's reasonable to expect ;)
On Thu, Mar 9, 2017 at 8:54 PM Erik de Castro Lopo [email protected] wrote:
Spoke to @jystic https://github.com/jystic about this at lunch. He's not (yet) convinced this is a good idea.
The Pros:
- The submodule command will be listed in the mafia help output making it easily discoverable.
- We can add both submodule add and submodule rm, the second of which is a glaring omission in the git submodule command.
The Cons:
- Ties mafia to git (but no more so that is already the case).
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ambiata/mafia/issues/127#issuecomment-285549901, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAQwhYEmdPMO0KMrQc0BUN-UbQCjvKdks5rkK1IgaJpZM4JFwpv .