HsYAML icon indicating copy to clipboard operation
HsYAML copied to clipboard

"HsYAML is tested using YAML-Test-Suite"

Open sjakobi opened this issue 3 years ago • 4 comments

…says the readme.

Are these tests automated somewhere? I suspect not. They probably should be though, so we don't accidentally break compatibility with the YAML spec.

sjakobi avatar Jun 16 '22 16:06 sjakobi

I think the run-tml[2] commands of the internal yaml-test executable are intended to execute this YAML-Test-Suite:

https://github.com/haskell-hvr/HsYAML/blob/603d8a23338db6abe5105c96ece182f2d930cf1f/src-test/Main.hs#L134-L135

Could this test suite be executed in CI?!

sjakobi avatar Jun 16 '22 16:06 sjakobi

There is this testsuite which is registered in HsYAML.cabal: https://github.com/haskell-hvr/HsYAML/blob/603d8a23338db6abe5105c96ece182f2d930cf1f/tests/Tests.hs

andreasabel avatar Jun 16 '22 16:06 andreasabel

There is this testsuite which is registered in HsYAML.cabal: https://github.com/haskell-hvr/HsYAML/blob/603d8a23338db6abe5105c96ece182f2d930cf1f/tests/Tests.hs

Yes, this testsuite is also mentioned in the README, but it doesn't seem to test compatibility with the YAML spec.

sjakobi avatar Jun 16 '22 16:06 sjakobi

Could this test suite be executed in CI?!

If this is added as a test-suite in HsYAML.cabal with build-tool-depends pointing to the executable, then it would be run in the automated CI without manual patching (just regeneration of haskell-ci.yml).

andreasabel avatar Jun 16 '22 16:06 andreasabel