github
github copied to clipboard
Partial escape in query string to make search work again
fixes #262 http-types and http-client had to be extended for partial escape. These versions are now in stackage quite a while. I built the structure that I assumed you had in mind (SearchRepoMod), but it is very tedious and in my opinion not worth the trouble. So I used two styles in GitHub.Endpoints.Search
- Using SearchRepoMod in: searchRepos
- Constructing the query directly: searchCode' [("q", [QE "language", QN ":", QE "haskell"]), ..
@tkvogt : Thanks for this PR!
It's been a while; do you want to finish this, fixing the conflicts and what remained to be done?
This is so long ago. I just remeber that it worked and was good enough for me. It turned into some kind of beauty contest, which I had no time for.
It turned into some kind of beauty contest, which I had no time for.
I understand. Sorry for that.
My priorities are rather:
- the functionality is faithful to the GitHub API
- there are tests or demos so the functionality can be verified
I didn't look closely at 1., but I noticed that 2. is satisfied (AllHaskellRepos
).
If you use stack, you can reference this pull request and try it like
- git: https://github.com/tkvogt/github.git
commit: 0e157e2e9c2f75e44e34bc0ffe67f2155326eba1
In my memory it worked. Of course If you somehow finish it, you are the hero.
Of course If you somehow finish it, you are the hero.
Got enough on my plate. I suppose this has to wait for someone with a genuine interest in this functionality to pick it up...