fix the PullRequest object so it can parse

[adnelson]

I'm not positive this covers every variant of a pull request event, but prior to this change the FromJSON instance failed to decode the example json (which is where the JSON I included here comes from) in the API docs, and now it does.

[adnelson]

Not sure why the PR builder is unable to find fixtures/pull-request.json; it's in the same directory as other fixtures and it worked locally

[adnelson]

What do you mean by using the real world response as a fixture?

[phadej]

@adnelson e.g. the current version of result for that the PR in your fixture https://api.github.com/repos/baxterthehacker/public-repo/pulls/1 has assignees list.

Real-world: don't copy old fixtures from somewhere, grab new ones from the API.

[adnelson]

@phadej I think the problem was that I was confusing the PullRequest and PullRequestEvent types. I'll add fixtures for each case and test them separately

[adnelson]

Alright, so I added three more fixtures, one that I had of the pull request event, and the two that you had given for pull requests, making four test cases in total. I added some logic which allows either the assignee or assignees keys, or both, to be present in a pull request blob.

[adnelson]

@phadej any thoughts on this?

[adnelson]

@phadej just checking in here...

[andreasabel]

@adnelson : New maintainer here.
Are you willing to fix the conflicts so that this PR can be merged (assuming it is still serving its purpose)?