network-transport-tcp icon indicating copy to clipboard operation
network-transport-tcp copied to clipboard

Published 20 hours ago • verified publisher icon haskell-distributed

Docs lie about default value of TCP_NODELAY

Open nh2 opened this issue 7 years ago • 0 comments

https://github.com/haskell-distributed/network-transport-tcp/blob/6757ce91eeb3fe67cde33f1f2178e090f8348345/src/Network/Transport/TCP.hs#L477

    -- | Should we set TCP_NODELAY on connection sockets?
    -- Defaults to True.
    , tcpNoDelay :: Bool

https://github.com/haskell-distributed/network-transport-tcp/blob/6757ce91eeb3fe67cde33f1f2178e090f8348345/src/Network/Transport/TCP.hs#L615

defaultTCPParameters = TCPParameters {
 ...
, tcpNoDelay = False

This inconsistency was introduced in https://github.com/haskell-distributed/network-transport-tcp/commit/859a1ade2331803d64daf9e9c011b3f2c9c2608b.

nh2 avatar Apr 13 '17 15:04 nh2