libsodium-bindings icon indicating copy to clipboard operation
libsodium-bindings copied to clipboard

Any plans to include `sel` in stackage?

Open Daniel-Diaz opened this issue 1 year ago • 15 comments

Thank you for these great bindings!

Is there any chance they will be included in future stackage snapshots?

Daniel-Diaz avatar Sep 15 '24 13:09 Daniel-Diaz

@Daniel-Diaz Hi! I have no idea how these things work, unfortunately.

Kleidukos avatar Sep 15 '24 13:09 Kleidukos

All that's needed is for the package to be included here: https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml

Daniel-Diaz avatar Sep 15 '24 13:09 Daniel-Diaz

There's more info in the readme: https://github.com/commercialhaskell/stackage/tree/master?tab=readme-ov-file#add-your-package

Daniel-Diaz avatar Sep 15 '24 13:09 Daniel-Diaz

Hmpm, https://docs.haskellstack.org/en/stable/travis_ci/ and https://packdeps.haskellers.com/ are unusable.

I'm not against the packages being present on Stackage, nor against accommodating Stackage by using good dependency bounds, but I am already spread so thin that this is not something I can do myself.

If you have a real need for sel and libsodium-bindings to be present on Stackage, you have my blessing to add them.

Kleidukos avatar Sep 15 '24 13:09 Kleidukos

Hmpm, https://docs.haskellstack.org/en/stable/travis_ci/ and https://packdeps.haskellers.com/ are unusable.

I'm not against the packages being present on Stackage, nor against accommodating Stackage by using good dependency bounds, but I am already spread so thin that this is not something I can do myself.

If you have a real need for sel and libsodium-bindings to be present on Stackage, you have my blessing to add them.

Yeah, it seems their readme might be out-of-date. I'll take a look.

Daniel-Diaz avatar Sep 15 '24 13:09 Daniel-Diaz

I needed this again, so I decided to take action this time. I would like to have the following packages added to stackage:

  • sel
  • libsodium-bindings
  • text-display

Do I still have your blessing to do this? If so, I commit to:

  • Adding the above packages under my name to stackage so that I get any pertinent notifications.
  • Upon receiving any notification, opening an issue on the original package repository.
  • If time permits, submitting a PR fixing the issue.

Let me know whether I have green light.

Thank you.

Daniel-Diaz avatar Mar 08 '25 09:03 Daniel-Diaz

Absolutely, you have my green light!

Kleidukos avatar Mar 08 '25 11:03 Kleidukos

For reference: https://github.com/commercialhaskell/stackage/pull/7706

Daniel-Diaz avatar Mar 08 '25 15:03 Daniel-Diaz

@Kleidukos

The following dependency bounds (in Hackage) are too restrictive:

  • text-display ^>=0.0
  • hedgehog ^>=1.4

This prevents the package from building with the current versions of these packages, which blocks it from being added to the next stackage snapshot.

The bounds have already been updated in the main branch. Simply releasing that or submitting a revision would fix this. A new release would allow sel to still build against older versions of text-display and hedgehog. A revision with a wider version tolerance could also achieve this.

These actions are beyond my control, so I let you decide.

Thanks.

Daniel-Diaz avatar Mar 09 '25 09:03 Daniel-Diaz

Excellent I'll do this today

Kleidukos avatar Mar 09 '25 11:03 Kleidukos

@Daniel-Diaz Sorry for the time it took. Is it better now?

Kleidukos avatar Mar 21 '25 09:03 Kleidukos

@Daniel-Diaz Sorry for the time it took. Is it better now?

Thanks! I think that will work.

Daniel-Diaz avatar Mar 21 '25 22:03 Daniel-Diaz

Sorry, I did find an issue.

The dependency on text-display was upgraded to 1.*, but the version of the code on Hackage (0.0.2.0) doesn't actually build against this range, due to the change on the output type of displayBuilder. Unfortunately, this renders the package unbuildable.

Daniel-Diaz avatar Mar 23 '25 12:03 Daniel-Diaz

@Daniel-Diaz Alright, I'll revert the metadata changes on Hackage. Maybe Stackage should target the next major version?

Kleidukos avatar Mar 23 '25 18:03 Kleidukos

@Daniel-Diaz Alright, I'll revert the metadata changes on Hackage. Maybe Stackage should target the next major version?

I think that's a good plan.

Daniel-Diaz avatar Mar 23 '25 18:03 Daniel-Diaz