hashview-agent icon indicating copy to clipboard operation
hashview-agent copied to clipboard

Change puts to use logger gem, improved detection of PID on windows

Open nicbrink opened this issue 7 years ago • 3 comments

Since it looks like logger is going to be used going forward, I went through and changed all the puts to use $log.info,$log.debug,$log.error type logic. The logging level can be set on line 5, however this should probably be moved to either the config file, or passes as a parameter to agent.rb.

Also discovered that on widows detection of the Hashcat PID was not reliable because of the 'ps aux' command. Moved to a native windows library improving the detection code and ensuring that when a task is killed on windows, that the agent will stop running the task.

nicbrink avatar Oct 22 '17 19:10 nicbrink

This looks great! Unfortunately, both @ccammilleri and myself will be out of town the next couple of weeks, but i look forward to testing/merging this when we get back.

i128 avatar Oct 24 '17 21:10 i128

Please, can you accept this pull request?

kiblik avatar Apr 30 '18 16:04 kiblik

sure, I'll test it soon and get it merged.

ccammilleri avatar Apr 30 '18 20:04 ccammilleri