hash icon indicating copy to clipboard operation
hash copied to clipboard

H-2206, H-2242: Support entities with multiple types in frontend, everywhere else

Open CiaranMn opened this issue 4 months ago β€’ 2 comments

🌟 What is the purpose of this PR?

Following work to enable entities to have multiple types in https://github.com/hashintel/hash/pull/4140, this PR adds support for multi-type entities to the rest of the application.

🚫 Blocked by

To be addressed before merging:

  • [ ] H-3379: Because changes to types (adding, upgrading) happen as soon as the user confirms them, rather than being part of the 'local draft changes', it's impossible to add some entity types to entities if they introduce new requirements (e.g. new required property), because there is no facility to make a type change and property changes at the same time. The ticket is to bring type changes into the same pool of local draft changes as property/link changes, so that users can create an update which both adds/upgrades a type and makes the entity valid for the change.
  • [ ] H-3410: Allow setting multiple types on an entity before it's even created (blocked by H-3379)

πŸ” What does this change?

  • TODO

Pre-Merge Checklist πŸš€

🚒 Has this modified a publishable library?

  • [x] This PR does not modify any publishable blocks or libraries, or modifications do not need publishing

πŸ“œ Does this require a change to the docs?

  • [x] The changes in this PR are internal and do not require a docs change

πŸ•ΈοΈ Does this require a change to the Turbo Graph?

The changes in this PR:

  • [x] do not affect the execution graph
  • [x] affected the execution graph, and the turbo.json's have been updated to reflect this
  • [x] I am unsure / need advice

⚠️ Known issues

To be addressed post-merge:

  1. H-3408: When a user wants to add/remove/upgrade a type, show the difference in properties/links it would create, and flag any blocking changes they need to make to properties/links to be able to create the update – currently, it's not possible to tell what needs to be fixed if anything is blocking the change.
  2. H-1834: Highlight validation errors in the form UI when attempting to submit an update to an entity, so that users know progressively what remains to be fixed (rather than just the initial list of changes based on types which (1) above implies)

🐾 Next steps

Fix the above known issues.

πŸ›‘ What tests cover this?

  • TODO

❓ How to test this?

  1. Can only be tested locally as it depends on changes to the Node API

πŸ“Ή Demo

TODO

CiaranMn avatar Oct 04 '24 14:10 CiaranMn