hash
hash copied to clipboard
H-3134: Apply ESLint autofixes
🌟 What is the purpose of this PR?
This PR adds a new ESLint configuration, which is more encompassing and stricter than the previous one.
This is the second PR, building on top of #4232, and applies all auto fixes. The next PRs will focus on different subpackages to remove the remaining errors.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
- [x] does not modify any publishable blocks or libraries, or modifications do not need publishing
📜 Does this require a change to the docs?
The changes in this PR:
- [x] are internal and do not require a docs change
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
- [x] affected the execution graph, and the
turbo.json's have been updated to reflect this
Benchmark results
@rust/graph-benches – Integrations
representative_read_multiple_entities
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| link_by_source_by_property | depths: DT=255, PT=255, ET=255, E=255 | $$1.99 \mathrm{s} \pm 5.40 \mathrm{ms}\left({\color{gray}-0.038 \mathrm{\%}}\right) $$ | Flame Graph |
| link_by_source_by_property | depths: DT=0, PT=2, ET=2, E=2 | $$1.03 \mathrm{s} \pm 6.25 \mathrm{ms}\left({\color{gray}-0.658 \mathrm{\%}}\right) $$ | Flame Graph |
| link_by_source_by_property | depths: DT=2, PT=2, ET=2, E=2 | $$1.03 \mathrm{s} \pm 2.66 \mathrm{ms}\left({\color{gray}-0.944 \mathrm{\%}}\right) $$ | Flame Graph |
| link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=0 | $$39.0 \mathrm{ms} \pm 269 \mathrm{μs}\left({\color{gray}-2.577 \mathrm{\%}}\right) $$ | Flame Graph |
| link_by_source_by_property | depths: DT=0, PT=0, ET=2, E=2 | $$405 \mathrm{ms} \pm 1.58 \mathrm{ms}\left({\color{gray}0.318 \mathrm{\%}}\right) $$ | Flame Graph |
| link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=2 | $$75.0 \mathrm{ms} \pm 383 \mathrm{μs}\left({\color{gray}-3.830 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_property | depths: DT=255, PT=255, ET=255, E=255 | $$2.89 \mathrm{s} \pm 10.1 \mathrm{ms}\left({\color{gray}-0.006 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_property | depths: DT=0, PT=2, ET=2, E=2 | $$981 \mathrm{ms} \pm 3.11 \mathrm{ms}\left({\color{gray}-3.833 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_property | depths: DT=2, PT=2, ET=2, E=2 | $$994 \mathrm{ms} \pm 3.97 \mathrm{ms}\left({\color{gray}-1.203 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_property | depths: DT=0, PT=0, ET=0, E=0 | $$37.4 \mathrm{ms} \pm 274 \mathrm{μs}\left({\color{gray}-0.070 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_property | depths: DT=0, PT=0, ET=2, E=2 | $$362 \mathrm{ms} \pm 1.61 \mathrm{ms}\left({\color{gray}-3.186 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_property | depths: DT=0, PT=0, ET=0, E=2 | $$41.2 \mathrm{ms} \pm 226 \mathrm{μs}\left({\color{gray}-1.570 \mathrm{\%}}\right) $$ | Flame Graph |
scaling_read_entity_linkless
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 100 entities | $$2.03 \mathrm{ms} \pm 10.2 \mathrm{μs}\left({\color{gray}0.119 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 10 entities | $$1.84 \mathrm{ms} \pm 7.10 \mathrm{μs}\left({\color{gray}0.170 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 1 entities | $$1.84 \mathrm{ms} \pm 8.47 \mathrm{μs}\left({\color{gray}-0.029 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 1000 entities | $$2.76 \mathrm{ms} \pm 10.3 \mathrm{μs}\left({\color{gray}-2.383 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 10000 entities | $$13.3 \mathrm{ms} \pm 160 \mathrm{μs}\left({\color{gray}-0.387 \mathrm{\%}}\right) $$ | Flame Graph |
representative_read_entity_type
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| get_entity_type_by_id | Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 |
$$1.41 \mathrm{ms} \pm 6.03 \mathrm{μs}\left({\color{gray}0.400 \mathrm{\%}}\right) $$ | Flame Graph |
scaling_read_entity_complete_one_depth
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 25 entities | $$76.0 \mathrm{ms} \pm 353 \mathrm{μs}\left({\color{gray}-1.039 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 5 entities | $$24.5 \mathrm{ms} \pm 222 \mathrm{μs}\left({\color{gray}1.55 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 50 entities | $$273 \mathrm{ms} \pm 1.53 \mathrm{ms}\left({\color{gray}0.048 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 10 entities | $$50.0 \mathrm{ms} \pm 1.19 \mathrm{ms}\left({\color{red}20.3 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 1 entities | $$19.8 \mathrm{ms} \pm 93.0 \mathrm{μs}\left({\color{gray}-0.936 \mathrm{\%}}\right) $$ | Flame Graph |
scaling_read_entity_complete_zero_depth
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 25 entities | $$3.13 \mathrm{ms} \pm 11.0 \mathrm{μs}\left({\color{red}22.5 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 5 entities | $$1.89 \mathrm{ms} \pm 11.1 \mathrm{μs}\left({\color{gray}-0.555 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 50 entities | $$4.20 \mathrm{ms} \pm 34.0 \mathrm{μs}\left({\color{red}6.90 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 10 entities | $$2.08 \mathrm{ms} \pm 19.3 \mathrm{μs}\left({\color{gray}1.16 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | 1 entities | $$1.86 \mathrm{ms} \pm 7.58 \mathrm{μs}\left({\color{gray}-0.014 \mathrm{\%}}\right) $$ | Flame Graph |
representative_read_entity
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 |
$$16.8 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{lightgreen}-7.460 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 |
$$16.8 \mathrm{ms} \pm 197 \mathrm{μs}\left({\color{gray}3.72 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 |
$$17.2 \mathrm{ms} \pm 239 \mathrm{μs}\left({\color{gray}1.48 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 |
$$16.9 \mathrm{ms} \pm 228 \mathrm{μs}\left({\color{gray}-3.447 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 |
$$16.8 \mathrm{ms} \pm 257 \mathrm{μs}\left({\color{lightgreen}-33.218 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 |
$$16.9 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}0.498 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 |
$$17.2 \mathrm{ms} \pm 228 \mathrm{μs}\left({\color{gray}3.93 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 |
$$16.7 \mathrm{ms} \pm 242 \mathrm{μs}\left({\color{lightgreen}-6.717 \mathrm{\%}}\right) $$ | Flame Graph |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 |
$$17.1 \mathrm{ms} \pm 262 \mathrm{μs}\left({\color{gray}2.09 \mathrm{\%}}\right) $$ | Flame Graph |
Closing following internal discussion.