hash icon indicating copy to clipboard operation
hash copied to clipboard

H-2927: Pass metadata alongside properties to Graph SDK

Open TimDiekmann opened this issue 1 year ago β€’ 1 comments

🌟 What is the purpose of this PR?

The Graph SDK currently merges properties and their metadata but metadata are almost never passed. As we're going to make dataTypeId required, this moves out the compound object generation and requires the full object to be passed.

🚫 Blocked by

  • #4630
  • #4631

πŸ” What does this change?

  • ...

Pre-Merge Checklist πŸš€

🚒 Has this modified a publishable library?

This PR:

  • [x] does not modify any publishable blocks or libraries, or modifications do not need publishing

πŸ“œ Does this require a change to the docs?

The changes in this PR:

  • [x] are internal and do not require a docs change

πŸ•ΈοΈ Does this require a change to the Turbo Graph?

The changes in this PR:

  • [x] do not affect the execution graph

⚠️ Known issues

🐾 Next steps

πŸ›‘ What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

πŸ“Ή Demo

TimDiekmann avatar Jun 21 '24 14:06 TimDiekmann

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 18.35%. Comparing base (31a49eb) to head (e9d1ab4). Report is 1845 commits behind head on main.

Files with missing lines Patch % Lines
.../hash-api/src/graph/knowledge/system-types/file.ts 0.00% 14 Missing :warning:
...s/hash-api/src/graph/knowledge/primitive/entity.ts 0.00% 11 Missing :warning:
.../hash-api/src/graph/knowledge/system-types/user.ts 0.00% 10 Missing :warning:
...sh-api/src/graph/knowledge/system-types/comment.ts 0.00% 9 Missing :warning:
...nowledge/system-types/linear-integration-entity.ts 0.00% 9 Missing :warning:
.../hash-api/src/graph/knowledge/system-types/page.ts 0.00% 8 Missing :warning:
...graph/knowledge/system-types/linear-user-secret.ts 0.00% 6 Missing :warning:
...@local/hash-isomorphic-utils/src/flows/mappings.ts 0.00% 6 Missing :warning:
...ities/flow-activities/write-google-sheet-action.ts 0.00% 5 Missing :warning:
...hash-api/src/graph/knowledge/system-types/block.ts 0.00% 5 Missing :warning:
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4632      +/-   ##
==========================================
- Coverage   18.39%   18.35%   -0.05%     
==========================================
  Files         482      482              
  Lines       16012    16020       +8     
  Branches     2448     2446       -2     
==========================================
- Hits         2946     2941       -5     
- Misses      13025    13038      +13     
  Partials       41       41              
Flag Coverage Ξ”
apps.hash-ai-worker-ts 1.49% <0.00%> (+<0.01%) :arrow_up:
apps.hash-api 1.19% <0.00%> (-0.01%) :arrow_down:
local.hash-backend-utils 9.24% <0.00%> (-0.01%) :arrow_down:
local.hash-isomorphic-utils 1.08% <0.00%> (-0.01%) :arrow_down:
local.hash-subgraph 25.96% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 21 '24 14:06 codecov[bot]