vscode-terraform icon indicating copy to clipboard operation
vscode-terraform copied to clipboard

Make Terraform extension available in "browser mode"

Open radeksimko opened this issue 4 years ago • 5 comments

Problem Statement

GitHub employees and other users use VS Code in the browser for various reasons. This extension currently isn't available for them.

Example https://github.dev/hashicorp/terraform-guides

Screenshot 2021-09-14 at 10 56 15

Expected User Experience

Extension is available to assist users in editing Terraform code in their browser, the same way as in desktop VS Code.

For example at https://vscode.dev/ or https://github.dev/

Proposal

https://code.visualstudio.com/docs/remote/codespaces#_why-is-an-extension-not-installable-in-the-browser

There is some documentation here: https://code.visualstudio.com/api/extension-guides/web-extensions

We could initially provide just a minimal extension for the web - e.g. with syntax highlighting only.

  • [ ] Investigate impact on telemetry logic
  • [ ] Investigate replacing of esbuild with webpack
  • [ ] Create browser entrypoint and link it from package.json per docs, e.g. "browser": "./dist/web/extension.js",

Longer-term we'd need to find out if there's any way or benefit from running LS in the browser - either via WASM or GopherJS.

radeksimko avatar Sep 14 '21 10:09 radeksimko

This would be awesome! I have been doing lots of PR reviews in the browser with github.dev

andymac4182 avatar Nov 10 '21 11:11 andymac4182

Please make this available for github codespaces.

Satak avatar Nov 19 '21 11:11 Satak

Hey @Satak, apologies for the delay in response. You should be able to use the extension in Codespaces:

image

Intellisense and other advanced language features work:

image

jpogran avatar Mar 09 '22 20:03 jpogran

@jpogran But it is not available for Codespaces in web browser:

image

Satak avatar Mar 10 '22 06:03 Satak

Yep! I misunderstood what you were referring to because the two are called different things: https://docs.github.com/en/codespaces/the-githubdev-web-based-editor

We currently work in the full Codespaces environment. We don't yet work in the web-based editor.

jpogran avatar Mar 10 '22 13:03 jpogran

I am exceedingly happy to announce, that as of v2.25.0, we now work in github.dev and vscode.dev in the browser!

jpogran avatar Nov 14 '22 17:11 jpogran

As mentioned, we provide a basic web version of the extension from v2.25.0, therefore I am going to close this issue. I have however created a separate one in https://github.com/hashicorp/vscode-terraform/issues/1287 to track possible future enhancements in this area. Comments are welcomed there.

radeksimko avatar Dec 02 '22 11:12 radeksimko

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Jan 02 '23 03:01 github-actions[bot]