vault
vault copied to clipboard
Backport of Check if storage should be updated during invalidation into release/1.17.x
Backport
This PR is auto-generated from #28059 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
:rotating_light:
Warning automatic cherry-pick of commits failed. If the first commit failed, you will see a blank no-op commit below. If at least one commit succeeded, you will see the cherry-picked commits up to, not including, the commit where the merge conflict occurred.
The person who merged in the original PR is: @davidadeleon This person should manually cherry-pick the original PR into a new backport PR, and close this one when the manual backport PR is merged in.
merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []
The below text is copied from the body of the original PR.
Description
The move command vault secrets move kv1 kv2 and vault auth move userpass1 userpass2 calls the sys/remount endpoint, which always gets forwarded to the active node. If performance standbys are present in the cluster, they will attempt to write to storage during invalidation. This PR makes sure that perf standbys don't write to storage, to avoid the logical.ErrReadOnly error.
TODO only if you're a HashiCorp employee
- [x] Labels: If this PR is the CE portion of an ENT change, and that ENT change is
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabels instead of the old stylebackport/x.x.xlabels. - [x] Labels: If this PR is a CE only change, it can only be backported to N, so use
the normal
backport/x.x.xlabel (there should be only 1). - [ ] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature of a public function, even if that change is in a CE file, double check that applying the patch for this PR to the ENT repo and running tests doesn't break any tests. Sometimes ENT only tests rely on public functions in CE files.
- [x] Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
- [ ] RFC: If this change has an associated RFC, please link it in the description.
- [x] ENT PR: If this change has an associated ENT PR, please link it in the description. Also, make sure the changelog is in this PR, not in your ENT PR.
Overview of commits
- 6558df47b414954398ab742fef3ac1295e5c98f8
CI Results: All Go tests succeeded! :white_check_mark:
Build Results: All builds succeeded! :white_check_mark: