vault icon indicating copy to clipboard operation
vault copied to clipboard

Backport of UI: remove pinned chrome version into release/1.17.x

Open hc-github-team-secure-vault-core opened this issue 1 year ago • 2 comments

Backport

This PR is auto-generated from #28159 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

:rotating_light:

Warning automatic cherry-pick of commits failed. If the first commit failed, you will see a blank no-op commit below. If at least one commit succeeded, you will see the cherry-picked commits up to, not including, the commit where the merge conflict occurred.

The person who merged in the original PR is: @hashishaw This person should manually cherry-pick the original PR into a new backport PR, and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

revert changes from #27580 which added a pinned chrome version to resolve test failures we were seeing.

We are reverting the changes because now we are seeing failures like:

error: Chrome
Error: Browser timeout exceeded: 10s
Error while executing test: Acceptance | wrapped_token query param functionality: it authenticates when used with the with=token query param
Stderr: 
 Fontconfig error: No writable cache directories
[0822/180212.113587:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process.

Overview of commits
  • 1488f0956d989f838c4c4c1d81746a3c325e66e2

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla-app[bot] avatar Aug 22 '24 20:08 hashicorp-cla-app[bot]

CI Results: All Go tests succeeded! :white_check_mark:

github-actions[bot] avatar Aug 22 '24 20:08 github-actions[bot]

On main we're observing that this doesn't alleviate our pains, and are reverting the change

hashishaw avatar Aug 23 '24 18:08 hashishaw