vault icon indicating copy to clipboard operation
vault copied to clipboard

Add Access Type and conditionally render WIF fields

Open Monkeychip opened this issue 6 months ago • 2 comments

Description

  • Adds a radio button for selecting Access Type. Defaults to type "iam" and only allows you to select "wif" if you're on an enterprise license. accessType is not a model/api attr so we manage it in the component.
  • See API docs here about the ent only attrs.
  • Clears WIF/IAM fields on toggle. WIF and IAM fields are mutually exclusive.
  • If WIF/IAM fields were set previously, you cannot change the access type.

This PR does not do

  • Add Default Issue field. Last PR coming after this.
  • Adds nice-to-have model validations to the root-config. I have a ticket for adding these if there is time. Because we have to sort through two sets of model validations, it's not straight forward to add and not a requirement so holding off in this PR.
  • You'll see this in the screenshare 👇. Right now, the enableInput component wraps the Secret Key if the model is not new. Ideally, we would only wrap it in this situation if there was an AcesssKey set (meaning they also set a SecretKey). This is a nice-to-have as it's a bit edgecase'y and involves some changes in FormFieldGroups—a widely used component.

Screenshare

https://github.com/user-attachments/assets/8ada20ca-c8e2-4a8e-8c77-c24a4e6edb19

Monkeychip avatar Aug 21 '24 23:08 Monkeychip