vault icon indicating copy to clipboard operation
vault copied to clipboard

Remove distinct_entities and non_entity_tokens from ResponseCounts and update docs

Open divyaac opened this issue 1 year ago • 2 comments

Description

Remove fields distinct_entities and non_entity_tokens from RespounseCounts structure, so that this is completely removed from the response. This change is NOT backwards compatible. This change follows the major change (https://github.com/hashicorp/vault/commit/b32231a9eb14e19b81e9a04f017d0ea783ddbcda) which contains the changelog.

ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6280

TODO only if you're a HashiCorp employee

  • [ ] Labels: If this PR is the CE portion of an ENT change, and that ENT change is getting backported to N-2, use the new style backport/ent/x.x.x+ent labels instead of the old style backport/x.x.x labels.
  • [ ] Labels: If this PR is a CE only change, it can only be backported to N, so use the normal backport/x.x.x label (there should be only 1).
  • [ ] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature of a public function, even if that change is in a CE file, double check that applying the patch for this PR to the ENT repo and running tests doesn't break any tests. Sometimes ENT only tests rely on public functions in CE files.
  • [ ] Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
  • [ ] RFC: If this change has an associated RFC, please link it in the description.
  • [ ] ENT PR: If this change has an associated ENT PR, please link it in the description. Also, make sure the changelog is in this PR, not in your ENT PR.

divyaac avatar Jul 23 '24 23:07 divyaac

CI Results: All Go tests succeeded! :white_check_mark:

github-actions[bot] avatar Jul 23 '24 23:07 github-actions[bot]

Build Results: All builds succeeded! :white_check_mark:

github-actions[bot] avatar Jul 23 '24 23:07 github-actions[bot]