vault icon indicating copy to clipboard operation
vault copied to clipboard

UI: redirect of URL change for KV v2 secrets engine does not consider type generic

Open luanaBanana opened this issue 1 year ago • 1 comments

Describe the bug This bug fix fixed the problem for secret engines of type kv and version 2 but does not consider secret engines of type generic and version 2.

To Reproduce Steps to reproduce the behavior:

  1. Select secret engine of type generic and version 2
  2. No secrets in this backend

Expected behavior Secrets should be shown.

Environment:

  • Vault Server Version: 1.16.2
  • Vault CLI Version (retrieve with vault version): -
  • Server Operating System/Architecture: RedHat 8.8

Vault server configuration file(s):

Additional context

the above mentioned fix introduces this condition:

if (secretEngine.type === 'kv' && secretEngine.version === 2) which does not include secretEngine.type === 'generic'

luanaBanana avatar May 24 '24 14:05 luanaBanana

@luanaBanana thank you for the detailed issue. I believe this bug was solved last week in PR #27019, which was backported to 1.16.3. Let me know if that does indeed solve the problem and I'll close this issue.

Monkeychip avatar May 24 '24 16:05 Monkeychip

@luanaBanana thank you for the detailed issue. I believe this bug was solved last week in PR #27019, which was backported to 1.16.3. Let me know if that does indeed solve the problem and I'll close this issue.

It indeed fixed the bug. I didn't catch that one. Thanks for letting me know

luanaBanana avatar May 30 '24 09:05 luanaBanana