vault icon indicating copy to clipboard operation
vault copied to clipboard

Backport of Update vault-plugin-auth-jwt to v0.20.3 into release/1.15.x

Open hc-github-team-secure-vault-core opened this issue 9 months ago • 4 comments

Backport

This PR is auto-generated from #26890 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

:rotating_light:

Warning automatic cherry-pick of commits failed. If the first commit failed, you will see a blank no-op commit below. If at least one commit succeeded, you will see the cherry-picked commits up to, not including, the commit where the merge conflict occurred.

The person who merged in the original PR is: @thyton This person should manually cherry-pick the original PR into a new backport PR, and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR was generated by a GitHub Action. Full log: https://github.com/hashicorp/vault/actions/runs/9009980689


Overview of commits
  • 51c851b416786aad285e1a140efbe4821ca7d780

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla-app[bot] avatar May 10 '24 00:05 hashicorp-cla-app[bot]

CI Results: All Go tests succeeded! :white_check_mark:

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]

@thyton I don't think we can backport v0.20.3 of the auth jwt plugin into Vault v1.15.x. If this fix must go into 1.15, we will need to backport the fix to the plugin's v0.19.x

fairclothjm avatar May 10 '24 13:05 fairclothjm

@thyton I have not verified the exact versions though so please double check that. Let me know if you need help!

fairclothjm avatar May 10 '24 13:05 fairclothjm

@fairclothjm Thank you for pointing this out. I think the version we need v0.17.3 of the auth jwt plugin based on https://github.com/hashicorp/vault/blob/release/1.15.x/go.mod#L134C1-L134C52.

I'm closing this automated backport PR.

thyton avatar May 14 '24 15:05 thyton