vault icon indicating copy to clipboard operation
vault copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

UI: wrap client count card in permission conditional

Open hellobontempo opened this issue 9 months ago • 2 comments

In https://github.com/hashicorp/vault/pull/26729 I removed the @license arg because the card no longer required the start time to pass to the activity log query. Inadvertently, this showed the card for users with just a default policy because the @license call would fail if a user didn't have permission.

This PR wraps the card in an explicit permissions conditional, which is the same one we use to hide the link in the sidebar for users who do not have permission to /activity. Tests have also been added to avoid a future regression.

User with default policy Screenshot 2024-05-07 at 11 51 55 AM

hellobontempo avatar May 07 '24 10:05 hellobontempo

Build Results: All builds succeeded! :white_check_mark:

github-actions[bot] avatar May 07 '24 10:05 github-actions[bot]

CI Results: All Go tests succeeded! :white_check_mark:

github-actions[bot] avatar May 07 '24 10:05 github-actions[bot]