vault icon indicating copy to clipboard operation
vault copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Add usePrivateIP for cloudsql postgresql instances

Open KyriosGN0 opened this issue 9 months ago • 2 comments

🛠️ Description

add the ability to speificy if the cloudsql postgresql instance has private ip we should use right now we fail if the instance has only public ip

Closes #26827

KyriosGN0 avatar May 04 '24 18:05 KyriosGN0

Hello @hsimon-hashicorp! We've been dreaming of using Vault to authenticate with gcp sql. Is there any chance you can help to facilitate/expedite the review of this PR? Thank you in advance!

sviatlo avatar May 11 '24 17:05 sviatlo

Hello @hsimon-hashicorp! We've been dreaming of using Vault to authenticate with gcp sql. Is there any chance you can help to facilitate/expedite the review of this PR? Thank you in advance!

Hi there! Thank you for the ping (genuinely, I appreciate it!) as well as your enthusiasm for this PR. I will check with our engineering and product management teams to see if we can get some eyes on this. I can't make any guarantees about timelines, but this does give me more data about community sentiment which is very valuable to me. Thanks again! ^_^

heatherezell avatar May 11 '24 22:05 heatherezell

Hey @hsimon-hashicorp Is there possibly some update about my PR?

KyriosGN0 avatar Jun 18 '24 15:06 KyriosGN0

hey @robmonte, Thanks you for the review, i addressed the nit in the code and added the required docs changes

KyriosGN0 avatar Jun 22 '24 13:06 KyriosGN0

@robmonte could you trigger the tests again ?

KyriosGN0 avatar Jun 25 '24 17:06 KyriosGN0