vault icon indicating copy to clipboard operation
vault copied to clipboard

Sync sublogger level with parent

Open mpalmi opened this issue 1 year ago • 1 comments

With the following commits, subloggers are now able to set their own levels while maintaining a hierarchical relationship to their parent/children.

https://github.com/hashicorp/go-hclog/pull/134 https://github.com/hashicorp/go-hclog/pull/137

This allows us to keep leaf sublogger levels in sync with their parent, unless specifically set otherwise.

As a result, we no longer have to track every leaf logger in the (Core).allLoggers slice. Instead, we can track main subsystem subloggers in allLoggers (e.g. core.replication), without having to manage every child (e.g. core.replication.index).

mpalmi avatar Dec 13 '23 14:12 mpalmi

CI Results: Failures:

Test Type Package Test Logs
vault TestSystemBackend_LoggersByName view test results
vault TestSystemBackend_LoggersByName/loggers-by-name-core view test results
vault TestSystemBackend_LoggersByName/loggers-by-name-identity view test results

github-actions[bot] avatar Dec 13 '23 14:12 github-actions[bot]