vault icon indicating copy to clipboard operation
vault copied to clipboard

Backport of Add stack trace to audit logging panic recovery into release/1.12.x

Open hc-github-team-secure-vault-core opened this issue 3 years ago • 0 comments

Backport

This PR is auto-generated from #18121 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

The below text is copied from the body of the original PR.


Adds a stack trace to the logs when we recover from a panic, otherwise we only get the panic error string, and no code location for where it came from.

The only other bit of production code we add a recover to is: https://github.com/hashicorp/vault/blob/c73a6a4a9e5d5b4e27a51102c8243351d40f1386/builtin/logical/ssh/path_issue_sign.go#L477

It wasn't clear to me that we would want a stack trace in that instance, so I've left it alone.


Overview of commits
  • 1d7c5db671e6700933663269c476ed98e70b22e3