vault
vault copied to clipboard
Mark deprecated builtins Removed
This PR drops the logical database builtins for 1.13. This might need a bit more polish in the form of Factory stubbing, but getting it into CI to get some free testing.
It looks like TestSecretsEnableCommand_Run
is consistently failing so we might have to update that test.
It looks like
TestSecretsEnableCommand_Run
is consistently failing so we might have to update that test.
Thanks @calvn! I'm looking into it right now, but I suspect it's related to the branch that this is based on. Updates coming soon.
Could you do a go mod tidy
to see if it changes the dependencies? I feel that removing 8k lines of code would allow us to remove some deps and/or upgrade others.
Could you do a
go mod tidy
to see if it changes the dependencies? I feel that removing 8k lines of code would allow us to remove some deps and/or upgrade others.
I thought about that and dropped this change, but on second thought, we can probably get rid of the mgo
dep:
$ git diff
diff --git a/go.mod b/go.mod
index 2af3b42184..0517d8a803 100644
--- a/go.mod
+++ b/go.mod
@@ -199,7 +199,6 @@ require (
google.golang.org/grpc v1.50.1
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0
google.golang.org/protobuf v1.28.1
- gopkg.in/mgo.v2 v2.0.0-20180705113604-9856a29383ce
gopkg.in/ory-am/dockertest.v3 v3.3.4
gopkg.in/square/go-jose.v2 v2.6.0
k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9
diff --git a/go.sum b/go.sum
index f277488de2..2215696078 100644
--- a/go.sum
+++ b/go.sum
@@ -2594,8 +2594,6 @@ gopkg.in/ini.v1 v1.66.2 h1:XfR1dOYubytKy4Shzc2LHrrGhU0lDCfDGG1yLPmpgsI=
gopkg.in/ini.v1 v1.66.2/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
gopkg.in/jcmturner/goidentity.v3 v3.0.0 h1:1duIyWiTaYvVx3YX2CYtpJbUFd7/UuPYCfgXtQ3VTbI=
gopkg.in/jcmturner/goidentity.v3 v3.0.0/go.mod h1:oG2kH0IvSYNIu80dVAyu/yoefjq1mNfM5bm88whjWx4=
-gopkg.in/mgo.v2 v2.0.0-20180705113604-9856a29383ce h1:xcEWjVhvbDy+nHP67nPDDpbYrY+ILlfndk4bRioVHaU=
-gopkg.in/mgo.v2 v2.0.0-20180705113604-9856a29383ce/go.mod h1:yeKp02qBN3iKW1OzL3MGk2IdtZzaj7SFntXj72NppTA=
gopkg.in/natefinch/lumberjack.v2 v2.0.0/go.mod h1:l0ndWWf7gzL7RNwBG7wST/UCcT4T24xpD6X8LsfU/+k=
gopkg.in/ory-am/dockertest.v3 v3.3.4 h1:oen8RiwxVNxtQ1pRoV4e4jqh6UjNsOuIZ1NXns6jdcw=
gopkg.in/ory-am/dockertest.v3 v3.3.4/go.mod h1:s9mmoLkaGeAh97qygnNj4xWkiN7e1SKekYC6CovU+ek=