vault
vault copied to clipboard
hashicorp
postgres multihost with pgx
hardly any changes were required as the pgx package can handle the multihost connection strings. Just had to revert back to pq package as older versions of Vault will not have the dbhelper package updated yet. Also updated with instructions on how to setup a HA postrgres cluster for testing the plugin.
Just had to revert back to pq package as older versions of Vault will not have the dbhelper package updated yet.
We shouldn't have to worry about older versions of Vault in this case since this is treated as a new feature and will only go into the next major Vault release (1.12).
Building this as an external plugin shouldn't be a problem either, as the plugin binary will be able to use the dbhelper package regardless of what version of Vault you're running.
Hey @moayadi Given our recent discussions, I feel it is okay to close this PR since the feature is already supported as of Vault 1.11 due to the switch to pgx. Let me know if you have any objections.
The test script you included was extremely helpful with investigating this feature. The only tweak to get the feature working is to add sleep statements (~20 seconds) at each point you stop a docker container, to allow enough time for the failover event to occur.
Hey @moayadi Given our recent discussions, I feel it is okay to close this PR since the feature is already supported as of Vault 1.11 due to the switch to pgx. Let me know if you have any objections.
The test script you included was extremely helpful with investigating this feature. The only tweak to get the feature working is to add sleep statements (~20 seconds) at each point you stop a docker container, to allow enough time for the failover event to occur.
no worries at all, PR can be closed.