vault
vault copied to clipboard
hashicorp
PKI - Honor header If-Modified-Since if present
Hello @cipherboy, opened this pull request just to make sure that what we have discussed for #3190 is still valid since there seem to have been many changes in the crl endpoints. So far, this PR has an implementation to honor the "If-Modified-Since" header, if present, in the crl and crl/pem endpoints. Feedback on it would be appreciated.
I still intended to test the implementation and also look at a possible refactoring of the patchFetch function.
Hi @Gabrielopesantos - please don't forget to add a changelog entry too. :) Please see the contributing.md for more details.
Sorry @Gabrielopesantos -- I've been on vacation for a bit, I'll take a look at this week now that I'm back :)
Ok, with this last commit I am happy with opening the pull request. I have made a small refactoring based on comments which I think is an improvement from what I had before. I think some of the stuff related to checking the header can moved from storage.go to a utils file (not sure what to call it). There is still also maybe an update in the Docs.
Regarding tests, I wouldn't minding doing them as there are still likely corner cases that I did not manually test or don't know about. However, as we might have merge conflicts and if you think we can make this release, I'm ok with other person taking from here. Let me know if there is anything else I can do regarding this PR, if not I will just come in the end to set what were your changes.
A few follow-up minor changes can be merged in the next PR.
Thank you @Gabrielopesantos for kicking this off and doing a lot of the work in this PR!!