vault
vault copied to clipboard

Published 20 hours ago •

Reame
Issues

fix bug with allowed_users_template and add allowed_domains_template for SSH role

Open f4z3r opened this issue 2 years ago • 4 comments

This implements the allowed_domains_template field when configuring SSH roles on the SSH secret engine (as explained in issue #10943). It also fixes an issue that allowed_users_template actually affected the domain templating. I also directly added the documentation for it.

Jun 18 '22 07:06 f4z3r

All committers have signed the CLA.

Jun 18 '22 07:06 hashicorp-cla

This should also fix #14901.

Jun 18 '22 11:06 f4z3r

@taoism4504 is any additional work required for this? Thanks 😃

Jul 13 '22 10:07 f4z3r

Thanks @f4z3r! I'll see if I can get an engineer to review this soon. :)

Jul 19 '22 18:07 heatherezell

Howdy @f4z3r, thanks for the contribution! This looks great!

Edit: Looks like there are a couple merge conflicts. If you can fix those up we can bring this in. Again, thanks for tackling this!

Aug 16 '22 17:08 schultz-is

Hi @schultz-is Thanks for the review. I rebased on the current state of main; conflicts should be resolved.

Aug 16 '22 19:08 f4z3r

Thanks for the contribution @f4z3r!

Aug 16 '22 19:08 schultz-is