vault-secrets-operator icon indicating copy to clipboard operation
vault-secrets-operator copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Fix: Overwriting tls.crt and tls.key when using secret type kubernetes.io/tls for VaultPKISecret (#658)

Open jacob-faber opened this issue 1 year ago • 3 comments

Fixes #658

jacob-faber avatar Mar 17 '24 05:03 jacob-faber

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 17 '24 05:03 hashicorp-cla

Thanks for the contribution @jacob-faber - I would be more in favour of making this change a bit simpler. We could just say that if there are any transformations defined for the destination then skip the hard coded data rendering.

benashz avatar Mar 18 '24 16:03 benashz

@benashz, Do you think https://github.com/hashicorp/vault-secrets-operator/blob/33c087f40dd4590fa76e14b78684c6134bf1e204/controllers/vaultpkisecret_controller.go#L232-L234 should be skipped too?

jacob-faber avatar Mar 19 '24 07:03 jacob-faber