vault-guides icon indicating copy to clipboard operation
vault-guides copied to clipboard

chore: add errcheck for parsing cli flags in plugins

Open thevilledev opened this issue 2 years ago • 0 comments

Add a missing error check to plugin examples when parsing CLI flags. At the moment a parse error will be hidden from the end-user and the execution continues. With this change execution fails if flags.Parse() returns an error.

Same issue applies to many existing plugin implementations, such as:

  • https://github.com/hashicorp/vault-auth-plugin-example/pull/32
  • https://github.com/hashicorp/vault-plugin-auth-kubernetes/pull/202

thevilledev avatar Jul 24 '23 18:07 thevilledev